daca: filter checker results when there are syntaxError/unknownMacro/etc#5214
Merged
Conversation
Collaborator
|
What is this change trying to solve? As these warnings are quite common in daca this leads to incomplete or even empty diffs, which is bad - see https://trac.cppcheck.net/ticket/12099. |
firewave
added a commit
to firewave/cppcheck
that referenced
this pull request
Oct 23, 2023
…wnMacro/etc (cppcheck-opensource#5214)" This reverts commit 7ff58da.
firewave
added a commit
to firewave/cppcheck
that referenced
this pull request
Oct 23, 2023
…wnMacro/etc (cppcheck-opensource#5214)" [skip ci] This reverts commit 7ff58da.
Collaborator
|
I guess the idea was that (resolved) critical errors should not cause diff changes for other error IDs? |
Collaborator
Probably - but the warnings are not global but per file. And they could originate from a header only. I think handling this (if it would actually work properly) would be rather complex and would not give much of an upside. We are not that deep into daca all the time. |
firewave
added a commit
to firewave/cppcheck
that referenced
this pull request
Oct 26, 2023
…wnMacro/etc (cppcheck-opensource#5214)" [skip ci] This reverts commit 7ff58da.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.